Refactor: Consolidate import datetime #34110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:webserver
eumiro
force-pushed
the
import-datetime
branch
from
74df0d9
to
eec9609
Compare
eumiro
requested review from
jedcunningham,
hussein-awala,
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
hussein-awala
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
This module is deprecated.
@eladkal is it ok to update it?
|
merge main to fix static checks |
uranusjr
approved these changes
Sep 5, 2023
potiuk
approved these changes
Sep 6, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several files with
from airflow.utils.timezone import datetimethat at the same timeimport datetime as dt, making the two variables confusing. How about changing thatairflow.utils.timezone.datetimeto a more descriptive name?