Refactor os.path.splitext to Path.* #34352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:Scheduler
ephraimbuddy
approved these changes
Sep 14, 2023
eumiro
requested review from
jedcunningham,
kaxil,
XD-DENG and
ashb
as code owners
Lee-W
approved these changes
Sep 15, 2023
uranusjr
reviewed
Sep 15, 2023
| @@ -1042,8 +1040,7 @@ def _collect_results_from_processor(self, processor) -> None: | |||
| run_count=self.get_run_count(processor.file_path) + 1, | |||
| ) | |||
| self._file_stats[processor.file_path] = stat | |||
|
|
|||
| file_name = os.path.splitext(os.path.basename(processor.file_path))[0].replace(os.sep, ".") | |||
There was a problem hiding this comment.
The final replace call is so weird… Since basename is called, the value just can never contain an os.sep in the first place.
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 4869575)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.9+ we can change that:
to