Respect soft_fail parameter in AthenaSensor #34553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
vincbeck
reviewed
Sep 22, 2023
| @@ -78,7 +78,11 @@ def poke(self, context: Context) -> bool: | |||
| state = self.hook.poll_query_status(self.query_execution_id, self.max_retries, self.sleep_time) | |||
|
|
|||
| if state in self.FAILURE_STATES: | |||
| raise AirflowException("Athena sensor failed") | |||
| # TODO: remove this if block when min_airflow_version is set to higher than 2.7.1 | |||
There was a problem hiding this comment.
Just out of curiosity. Why? Why we no longer need this check from 2.7.1?
There was a problem hiding this comment.
@vincbeck Here - #33405 (comment)
vincbeck
approved these changes
Sep 22, 2023
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to solve the issue that the soft_fail argument in AthenaSensor is not respected.