Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what landing time means in doc #34608

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

dstandish
Copy link
Contributor

Slight clarification

@dstandish dstandish requested a review from potiuk as a code owner September 25, 2023 18:21
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. kind:documentation labels Sep 25, 2023
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question that I have with the re-description but I am not expert - how about manually triggered DAGs - this is then calculated based on the logical date and not data interval, correct? Worth mentioning here?

Is it worth adding that any preceeding tasks and scheduling delays irrespective of the acutal task execution time still pay into the landing time?

@dstandish
Copy link
Contributor Author

dstandish commented Sep 25, 2023

One question that I have with the re-description but I am not expert - how about manually triggered DAGs - this is then calculated based on the logical date and not data interval, correct? Worth mentioning here?

There is always a data interval, isn't there? Just sometimes end might equal start. I think what I wrote is always true.

Is it worth adding that any preceeding tasks and scheduling delays irrespective of the acutal task execution time still pay into the landing time?

If you make a formal suggestion i'll review it.

@dstandish
Copy link
Contributor Author

Is it worth adding that any preceeding tasks and scheduling delays irrespective of the acutal task execution time still pay into the landing time?

@jens-scheffler-bosch i will just merge this now, but if you want to refine it, feel free to tag me

@dstandish dstandish merged commit f99e65b into apache:main Sep 25, 2023
@dstandish dstandish deleted the landing-times-doc-cleanup branch September 25, 2023 21:52
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants