Fix WSGI middleware example in the doc by import AUTH_REMOTE_USER from fab #34721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Oct 3, 2023
utkarsharma2
approved these changes
Oct 3, 2023
|
I wonder if this should be covered by AIP-56 cc @vincbeck |
It is something that we might have moved aspart of AIP-56, but this definitely helps AIP-56 :) Thank you! |
vincbeck
approved these changes
Oct 3, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit feaa508)
ephraimbuddy
added
type:doc-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34720
The module
airflow.www.fab_security.managerdoesn't haveAUTH_REMOTE_USER:and we should not import objects from 3rd party packages through Airflow package to avoid circular import.
This PR updates the example in the doc by importing the object from
flask_appbuilder.const.