REST API: Fix wrong plugin schema #34858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We serialize some plugin's fields as dictionaries leading to errors when accessing the `/plugins` endpoint. Here's the error: ValueError: dictionary update sequence element #0 has length 1; 2 is required The fields are lists of strings and this PR addresses it.
ephraimbuddy
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
|
I'm not sure how we can test this. Create a Plugin? |
|
We already have tests to test the endpoint, but those fields are all empty in the stub plugin so it does not reflect the change. Maybe it would be possible to add those to the test. |
Yeah, Looking at adding possible items to the fields |
uranusjr
approved these changes
Oct 12, 2023
eladkal
approved these changes
Oct 12, 2023
ephraimbuddy
added a commit
that referenced
this pull request
Oct 29, 2023
* REST API: Fix wrong plugin schema We serialize some plugin's fields as dictionaries leading to errors when accessing the `/plugins` endpoint. Here's the error: ValueError: dictionary update sequence element #0 has length 1; 2 is required The fields are lists of strings and this PR addresses it. * fixup! REST API: Fix wrong plugin schema * Add test at the endpoint * fixup! Add test at the endpoint (cherry picked from commit 474fa4d)
ephraimbuddy
added a commit
that referenced
this pull request
Oct 30, 2023
* REST API: Fix wrong plugin schema We serialize some plugin's fields as dictionaries leading to errors when accessing the `/plugins` endpoint. Here's the error: ValueError: dictionary update sequence element #0 has length 1; 2 is required The fields are lists of strings and this PR addresses it. * fixup! REST API: Fix wrong plugin schema * Add test at the endpoint * fixup! Add test at the endpoint (cherry picked from commit 474fa4d)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We serialize some plugin's fields as dictionaries leading to errors when accessing the /plugins endpoint.
Here's the error:
ValueError: dictionary update sequence element #0 has length 1; 2 is required
The fields are lists of strings and this PR addresses it.