-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task parameter to set custom logger name #34964
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7a0f1c4
feat: Implement customizable logger name
joffreybienvenu-infrabel 5d8eb9e
feat: Add tests
joffreybienvenu-infrabel 1bef39a
feat: Implement logger config for Hooks
joffreybienvenu-infrabel db3a91e
feat: Move logger_name assignment into LoggingMixin
joffreybienvenu-infrabel ec04689
fix: Apply static-checks formatting
joffreybienvenu-infrabel 445adb3
feat: Implement customizable logger name
joffreybienvenu-infrabel 7beb1a3
fix: Apply static-checks formatting
joffreybienvenu-infrabel ac8a104
feat: Make logger_name a child logger of 'airflow.tasks' for Operator…
joffreybienvenu-infrabel 8bc0466
fix: Refactor tests and typing for Hooks logger name
joffreybienvenu-infrabel dfa7789
fix: Add partial init for logger name
joffreybienvenu-infrabel 67497cf
feat: Add documentation about custom logger name
joffreybienvenu-infrabel 9d9b351
fix: Correctly format code in logging documentation
joffreybienvenu-infrabel a9e8540
fix: Correctly capture docker hooks in test
joffreybienvenu-infrabel 3dc0b81
feat: Implement customizable logger name
joffreybienvenu-infrabel dc3c7eb
fix: Apply static-checks formatting
joffreybienvenu-infrabel a80e84a
feat: Make logger_name a child logger of 'airflow.tasks' for Operator…
joffreybienvenu-infrabel 90e4ae7
fix: Refactor tests and typing for Hooks logger name
joffreybienvenu-infrabel fc7bcaa
fix: Rename `_parent_logger` to `_parent_logger_name`
joffreybienvenu-infrabel a7bbcea
fix: Simplify logger name creation + rename `_parent_logger` to `_log…
joffreybienvenu-infrabel 13ba890
fix: Correctly explain default logger in docstring
joffreybienvenu-infrabel 46e776b
feat: Implement back support for pickling logger
joffreybienvenu-infrabel 002fbae
fix: store logger presence as bool instead of name
joffreybienvenu-infrabel 5c35270
feat: Set back getstate/setstate to original + make `_log` None at se…
joffreybienvenu-infrabel b5c8422
fix: Correctly use pydantic's deep_update
joffreybienvenu-infrabel 74195a8
fix: Remove _log only if it exists
joffreybienvenu-infrabel ded2f91
fix: Remove `_log` None creation in setstate
joffreybienvenu-infrabel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from __future__ import annotations | ||
|
||
from airflow.hooks.base import BaseHook | ||
|
||
|
||
class TestBaseHook: | ||
def test_hook_has_default_logger_name(self): | ||
hook = BaseHook() | ||
assert hook.log.name == "airflow.task.hooks.airflow.hooks.base.BaseHook" | ||
|
||
def test_custom_logger_name_is_correctly_set(self): | ||
hook = BaseHook(logger_name="airflow.custom.logger") | ||
assert hook.log.name == "airflow.task.hooks.airflow.custom.logger" | ||
|
||
def test_empty_string_as_logger_name(self): | ||
hook = BaseHook(logger_name="") | ||
assert hook.log.name == "airflow.task.hooks" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it unused.
And why we need
pydantic
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As user, I want to add custom loggers and their related handlers in the "LOGGING_CONFIG" dictionary. I want also to keep everything already defined there (without erasing them). This logging config dict is a deep nested structure.
Thus, to have a concise and versatile example, I use
deep_update
which will merge in depth two dicts (unlikedict.update()
which merge only at root level). Unless you prefer an example without it ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Taragolis ?