Fix get_plugin_info for class based listeners.
#35022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
approved these changes
Oct 18, 2023
ephraimbuddy
approved these changes
Oct 18, 2023
JDarDagran
force-pushed
the
fix-plugin-info-for-listeners
branch
from
7b1f498 to
51f2ebe
Compare
potiuk
approved these changes
Oct 18, 2023
JDarDagran
force-pushed
the
fix-plugin-info-for-listeners
branch
from
51f2ebe to
3f53dce
Compare
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
fix-plugin-info-for-listeners
branch
from
3f53dce to
9151a4b
Compare
jedcunningham
approved these changes
Oct 18, 2023
eladkal
approved these changes
Oct 18, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 29, 2023
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> (cherry picked from commit a74ec40)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> (cherry picked from commit a74ec40)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was wrong assumption that listeners are always modules. Listeners may also be classes - examples are OpenLineageListener and ClassBasedListener from unit tests.