Switch from Black to Ruff formatter #35287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
jlaneve
changed the title
|
Looks like it works. Care to undraft it ? |
Taragolis
reviewed
Oct 31, 2023
Comment on lines
+68
to
+70
| TEST_ENTRY_PATH: ( | ||
| str | ||
| ) = f"projects/{{}}/locations/{TEST_LOCATION}/entryGroups/{TEST_ENTRY_GROUP_ID}/entries/{TEST_ENTRY_ID}" |
There was a problem hiding this comment.
That it also looks less readable rather than black formatting
vincbeck
approved these changes
Oct 31, 2023
jlaneve
requested review from
eladkal,
o-nikolas,
hussein-awala,
mik-laj,
uranusjr,
ryanahamilton,
bbovenzi,
pierrejeambrun,
ephraimbuddy and
XD-DENG
as code owners
|
note that I added back inline tuples - turns out they were actually correct. see https://github.com/apache/airflow/actions/runs/6708119087/job/18230292697 |
kaxil
approved these changes
Oct 31, 2023
hussein-awala
approved these changes
Oct 31, 2023
potiuk
approved these changes
Oct 31, 2023
Taragolis
approved these changes
Oct 31, 2023
|
The current constraints failure is unrelated and affects other PRs too, example #35312 , merging this PR |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
This PR switches the formatter we use from Black to Ruff, now that Ruff's introduced a [formatter](https://docs.astral.sh/ruff/formatter/). The Ruff formatter is ~30x as fast as Black, and we already use Ruff for linting. This PR also upgrades the version of Ruff to the latest. Note that this doesn't swap the formatter used in inline Python code in the docs as I haven't seen an easy way of getting the Ruff formatter working with it. Because of this, a lot of the Black code hasn't been removed (i.e. the code to upgrade black, etc).
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the formatter we use from Black to Ruff, now that Ruff's introduced a formatter. This PR also upgrades the version of Ruff to the latest.
Running locally:
This represents means Ruff is ~40x faster than Black (when there are no changes - when there are changes, I've seen it even higher).
Note that this doesn't swap the formatter used in inline Python code in the docs as I haven't seen an easy way of getting the Ruff formatter working with it. Because of this, a lot of the Black code hasn't been removed (i.e. the code to upgrade black, etc).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.