-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs on objectstorage #35294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more explanations, limitations and add example of attaching a filesystem.
bolkedebruin
requested review from
eladkal,
o-nikolas and
potiuk
as code owners
October 31, 2023 12:32
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon-aws
AWS/Amazon - related issues
labels
Oct 31, 2023
potiuk
reviewed
Oct 31, 2023
@@ -38,6 +44,21 @@ scheme. | |||
it depends on ``aiobotocore``, which is not installed by default as it can create dependency | |||
challenges with ``botocore``. | |||
|
|||
Cloud Object Stores are not real file systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big +10 on that. People do not understand that and have weird expectations about object storages.
potiuk
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ all the clarifications here. Very good update.
Taragolis
approved these changes
Oct 31, 2023
eladkal
approved these changes
Oct 31, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Improve docs on objectstorage Add more explanations, limitations and add example of attaching a filesystem.
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AIP-58
area:providers
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
kind:documentation
provider:amazon-aws
AWS/Amazon - related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more explanations, limitations and add example of attaching a filesystem.
cc @Taragolis
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.