Infinite UI redirection loop after deactivating an active user

[ivan-afonichkin]

This PR fixes an infinite redirection loop to /logout when deactivating logged in user.

closes: #35335

[potiuk]

Would be great to get a unit test for that one - to avoid regression

[ivan-afonichkin]

@potiuk I was just working on it :)

[potiuk]

Some static checks (looks like space). I do recommend to install pre-commit (as usual :)) - then it will automatically fix things for you at commit time.

[hussein-awala]

The goal of the unit tests is:

1. testing if our code works as expected
2. avoiding breaking the functionality of the code in the future

So, when you want to write a new test for a bug fix, the test should fail without the fix and pass after implementing it, which is not the case here.

[hussein-awala]

LGTM

[eladkal]

BTW same issue happens if user try to login without permission on airflow homepage.
It is resulted in endless redirect from homepage to login and then from login to home.

We probably need to handle this case as well.

[potiuk]

BTW same issue happens if user try to login without permission on airflow homepage. It is resulted in endless redirect from homepage to login and then from login to home.

We probably need to handle this case as well.

No permissions? You mean a real users that has no roles assigned at all ?