Cleanup code for elasticsearch<8 #35707
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:elasticsearch
labels
There was a problem hiding this comment.
Agree with @Taragolis to remove it altogether from the documentation, but also updating the doc here pending min version decision sounds good.
eladkal
changed the title
use_ssl parameter
eladkal
changed the title
| @@ -671,14 +671,11 @@ def test_retrieve_config_keys(): | |||
| """ | |||
| with conf_vars( | |||
| { | |||
| ("elasticsearch_configs", "use_ssl"): "True", | |||
There was a problem hiding this comment.
I think we need to keep it in the tests for check that we do not use non-existed parameters
There was a problem hiding this comment.
Which parameter are you worried about?
There was a problem hiding this comment.
("elasticsearch_configs", "use_ssl"): "True", This mostly for check that we remove it from resulting arguments here
There was a problem hiding this comment.
yes but we no longer need it because we are on elasticsearch>7
the only reference to this parameter was in the docs which was wrong
| @@ -671,14 +671,11 @@ def test_retrieve_config_keys(): | |||
| """ | |||
| with conf_vars( | |||
| { | |||
| ("elasticsearch_configs", "use_ssl"): "True", | |||
There was a problem hiding this comment.
("elasticsearch_configs", "use_ssl"): "True", This mostly for check that we remove it from resulting arguments here
Starting
elasticsearch>=8there is no moreuse_sslsee https://github.com/apache/airflow/pull/33135/files#r1285347163
mentioning also open question about supporting
elasticsearch<8#33281 (comment)
cc @sunank200 @Owen-CH-Leung
EDIT:
This PR practically reverts #33281 as provider setup is to support elasticsearch>=8
airflow/airflow/providers/elasticsearch/provider.yaml
Line 62 in 177da90
Thus users can't install older version of the library anyway.