Set mark_end_on_close after set_context #35761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ES task handler, set_context applies its own logic for mark_end_on_close, so it we must set the attr after for our override to persist.
dstandish
force-pushed
the
set-end-marker-behavior-after-set-context
branch
from
9565326
to
528883b
Compare
eladkal
approved these changes
Nov 21, 2023
pankajkoti
approved these changes
Nov 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 23, 2023
In ES task handler, set_context applies its own logic for mark_end_on_close, so it we must set the attr after for our override to persist.
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
In ES task handler, set_context applies its own logic for mark_end_on_close, so it we must set the attr after for our override to persist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ES task handler, set_context applies its own logic for mark_end_on_close, so it we must set the attr after for our override to persist.