Fix git-sync-init resources indent #35824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
jscheffl
approved these changes
Nov 23, 2023
eladkal
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
I agree with @jscheffl
Wrong indent can be on every line its not so simple to cover.
WDYT @hussein-awala ?
romsharon98
force-pushed
the
bug/fix-git-sync-resources
branch
from
27d9b39
to
20a3f60
Compare
romsharon98
force-pushed
the
bug/fix-git-sync-resources
branch
from
20a3f60
to
e96c87c
Compare
Okay, I will try to add a test later. |
hussein-awala
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35815
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.