Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Pytest-asyncio to < 0.23.1 #36037

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 3, 2023

Seems that pytest-asyncio 0.23.1 break our asyncio tests. We are temporarily limiting it until
pytest-dev/pytest-asyncio#703 is solved or answered.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Seems that pytest-asyncio 0.23.1 break our asyncio tests. We are
temporarily limiting it until
pytest-dev/pytest-asyncio#703 is
solved or answered.
@eladkal eladkal merged commit 9845b40 into apache:main Dec 3, 2023
18 checks passed
potiuk added a commit to potiuk/airflow that referenced this pull request Dec 4, 2023
Seems that the pytest-asyncio problem was already introduced by
0.23.0. In order to allow tests passing now, we should limit it
to below that version (follow up after apache#36037)
eladkal pushed a commit that referenced this pull request Dec 4, 2023
Seems that the pytest-asyncio problem was already introduced by
0.23.0. In order to allow tests passing now, we should limit it
to below that version (follow up after #36037)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 5, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
Seems that pytest-asyncio 0.23.1 break our asyncio tests. We are
temporarily limiting it until
pytest-dev/pytest-asyncio#703 is
solved or answered.

(cherry picked from commit 9845b40)
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
Seems that the pytest-asyncio problem was already introduced by
0.23.0. In order to allow tests passing now, we should limit it
to below that version (follow up after #36037)

(cherry picked from commit cc2521c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants