-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starting triggerer for system-tests #36236
Conversation
Can you explain to me how you run the system tests? I do this by setting the env var @o-nikolas @potiuk
So I added the Can you tell me an example system test that I can find that depends on triggerer so that I can run that example and check if it works? |
We use something like:
There is no such test currently, since triggerer wasn't supported (kind of a chicken and egg problem). You'll have to take an existing test and update it to be deferrable. It shouldn't be too hard, you'll just have to pass a deferrable flag through to an operator. @syedahsn any suggestions or corrections? Lastly, I'm not sure how well the DebugExecutor will handle the deferring though, that will be interesting to see. |
Most of the system tests can be run in deferrable mode by taking one of the supported operators/sensors and passing |
b08bb6d
to
c6b6b6a
Compare
ah this will involve setting up the third party system config to run the test right.. I completely forgot about that part and I don't have an account personally to up and run these tests. Is there any other way for me to do it? Can I push this code and will that be run as part of the Github actions CI pipeline test? @potiuk @o-nikolas @syedahsn |
The code will run as Airflow CI, but the system tests wont be executed. Since Airflow as a community can't be on the hook for those infrastructure costs. As a single user doing some testing, I think it shouldn't be too hard to find a system test that would be well within the AWS free tier and not cost you any money at all to run. But if the task is getting too overwhelming from the perspective, feel free to put what you have in a PR now and we can take it over when we find the time. |
Yeah. you can even test some simple tests using free tier of AWS. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
i will reopen the issue after adding simple test with free tier of AWS. |
@o-nikolas @syedahsn @potiuk any idea how i can reopen this PR. |
reopened. |
Closing this once since #39176 has resolved it |
closes: #31826
related: #31826
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.