Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admonitions in Python operator doc to reflect sentiment #36340

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Dec 21, 2023

Within the Python operator how-to guide, there are doc admonitions that don't necessarily reflect the sentiment of the call-out. For example, there are several places where there is a recommendation to use the TaskFlow version of an operator, but the admonition is a warning; this is more of a tip when authoring DAGs.

This PR hopes to match the sentiment of the call-out with an "appropriate" admonition for better context and visibility when reading the doc.

Within the Python operator how-to guide, there are doc admonitions that don't necessarily reflect the sentiment of the call-out. For example, there are several places where there is a recommendation to use the TaskFlow version of an operator but the admonition is a warning; this is more of a tip when authoring DAGs.

This PR hopes to match the sentiment of the call-out with an "appropriate" admonition in the doc for better context and visbility when reading the doc.
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation labels Dec 21, 2023
@josh-fell
Copy link
Contributor Author

Should it help on what the new version would look like for context:

Screen.Recording.2023-12-20.at.10.11.58.PM.mov

@Lee-W
Copy link
Member

Lee-W commented Dec 21, 2023

Just checked https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/python.html. It currently looks like
image. It looks much better after this change

@josh-fell
Copy link
Contributor Author

Just checked https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/python.html. It currently looks like image. It looks much better after this change

Glad to hear it! I think it might behoove us to modify the styling for these admonitions on the site (e.g. maybe "warning" shouldn't be gray?), plus I think there tends to be an overuse of "warning" and that might be copy/paste or just potential styling choice, not sure.

@Taragolis
Copy link
Contributor

e.g. maybe "warning" shouldn't be gray?

+1, grey it is looks like something unimportant

@potiuk
Copy link
Member

potiuk commented Dec 21, 2023

I had to look up what admonition is (TIL - thanks @josh-fell :) ) . Looks cool

@potiuk potiuk merged commit f76060c into apache:main Dec 21, 2023
51 checks passed
@josh-fell josh-fell deleted the taskflow-tips branch December 21, 2023 14:52
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.1 milestone Jan 10, 2024
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Jan 10, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
Within the Python operator how-to guide, there are doc admonitions that don't necessarily reflect the sentiment of the call-out. For example, there are several places where there is a recommendation to use the TaskFlow version of an operator but the admonition is a warning; this is more of a tip when authoring DAGs.

This PR hopes to match the sentiment of the call-out with an "appropriate" admonition in the doc for better context and visbility when reading the doc.

(cherry picked from commit f76060c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants