-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change spark connection form and add spark connections docs #36419
Conversation
@Taragolis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one small NIT from my side
docs/apache-airflow-providers-apache-spark/connections/spark-sql.rst
Outdated
Show resolved
Hide resolved
cfbf318
to
6359a30
Compare
1bd0bc8
to
274b306
Compare
docs/apache-airflow-providers-apache-spark/connections/spark.rst
Outdated
Show resolved
Hide resolved
@shohamy7 Have you tried to create a connection that isn't one of the connections being updated here? Behind the scenes with connections, all of the connection form data is submitted across all connection types. My concern is that adding the |
@josh-fell airflow/airflow/providers/hashicorp/hooks/vault.py Lines 380 to 386 in 71314b8
I will push a fix with default values. |
274b306
to
7edb86b
Compare
7edb86b
to
f149819
Compare
How should we pass the extra params that have been removed in this PR now? |
It's not removed. |
But how do I pass the extra parameters then? If I cant add them in the UI? |
Related: #28790
This PR aims to add docs about each Spark connection in a separate page.
In addition, adding a more user-friendly connection form for Spark and Spark SQL connection
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.