Add jira connection docs and UI form #36458
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:atlassian-jira
labels
| @@ -60,8 +60,7 @@ def get_conn(self) -> Jira: | |||
| # more can be added ex: timeout, cloud, session | |||
|
|
|||
| # verify | |||
| if "verify" in extra_options and extra_options["verify"].lower() == "false": | |||
| verify = False | |||
| verify = bool(extra_options.get("verify", verify)) | |||
There was a problem hiding this comment.
I'm not sure. Don't we need to verify whether the value is "false" or not? The boolean value of "false" is True
>>> bool("false")
True
There was a problem hiding this comment.
@Lee-W
You are right.
I've checked and the verify parameter type will be bool so we don't need this.
However, I wonder if this can lead to backward compatibility error. Maybe we should stick to the old mechanism that uses string instead of bool, WDYT?
There was a problem hiding this comment.
I prefer to deprecate first. We can accept both bool and string. Make the necessary adjustments under the hood. For the old style to raise deprecation warning and then remove completely in next major release.
For cases where we can't deprecate first and we can introduce breaking change directly (we prefer not to do this but if we must we can)
shohamy7
force-pushed
the
add-docs-to-jira-connection
branch
from
9f51c0b to
48a5aff
Compare
|
@eladkal ? |
Related: #28790
Add docs about the Jira connection and creating dedicated UI form in the UI
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.