Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated config.yml for environment variable sql_alchemy_connect_args #36526

Merged
merged 11 commits into from
Jan 25, 2024

Conversation

koushik-rout-samsung
Copy link
Contributor

@koushik-rout-samsung koushik-rout-samsung commented Jan 2, 2024

closes: #36207

Change description:
Updated config.yml for environment variable sql_alchemy_connect_args

Modified the existing example value to include dictionary parameters for setting up postgresql db connection.

Copy link

boring-cyborg bot commented Jan 2, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

airflow/config_templates/config.yml Outdated Show resolved Hide resolved
added more description
@dirrao dirrao requested a review from potiuk January 9, 2024 06:26
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong import.

@eladkal eladkal added this to the Airflow 2.8.2 milestone Jan 15, 2024
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Jan 15, 2024
@potiuk potiuk merged commit 8fd9fdb into apache:main Jan 25, 2024
55 checks passed
Copy link

boring-cyborg bot commented Jan 25, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

jedcunningham pushed a commit that referenced this pull request Feb 9, 2024
…36526)

* Update config.yml

* Updated config.yml

added more description

* conf update

* lint check update

* Update config.yml

extra space removed

* Update config.yml

change for pytest

(cherry picked from commit 8fd9fdb)
potiuk pushed a commit that referenced this pull request Feb 13, 2024
…36526)

* Update config.yml

* Updated config.yml

added more description

* conf update

* lint check update

* Update config.yml

extra space removed

* Update config.yml

change for pytest

(cherry picked from commit 8fd9fdb)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
…36526)

* Update config.yml

* Updated config.yml

added more description

* conf update

* lint check update

* Update config.yml

extra space removed

* Update config.yml

change for pytest

(cherry picked from commit 8fd9fdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variable AIRFLOW__DATABASE__SQL_ALCHEMY_CONNECT_ARGS not parsed correctly
5 participants