-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent celery command autoscale misconfig #36576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static checks are failing. I would request you to use pre commit hooks or breeze CLI static checks.
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#:~:text=available%20bash%20scripts.-,Pre%2Dcommit%20hooks,on%20and%20make%20them%20fast.
8401312
to
42709e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing test cases are failing. Can you update the existing ones and add the new test case?
hi @dirrao yes the static checks are expected to fail. I will need response for this comment #35332 (comment) to proceed further with this. |
b5bc45b
to
f281155
Compare
f281155
to
0882e7f
Compare
i have fixed some parts in documentation alone here in this PR. The actual issue is not an issue and therefore I just enhanced the docs alone |
closes: #35332
related: #35332
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.