Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of hovered navbar colors #36631

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

ncrocfer
Copy link
Contributor

@ncrocfer ncrocfer commented Jan 6, 2024

This PR is a follow up of the #35505 and #35553 ones to customize the navbar color.

When we hover the links with dark colors we can have this behavior with the background color:

navbar_color = #760000
navbar_text_color = #d7cece
Capture d’écran 2024-01-06 à 12 49 32

With these new settings the user can override the hovered background and text colors:

navbar_hover_color = #4c0102
navbar_text_hover_color = #d7cfce
Capture d’écran 2024-01-06 à 12 52 21

cc @vchiapaikeo @eladkal @kaxil @jedcunningham


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jan 6, 2024
Copy link
Contributor

@vchiapaikeo vchiapaikeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks good to me!

airflow/config_templates/config.yml Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
@hussein-awala hussein-awala added this to the Airflow 2.9.0 milestone Jan 6, 2024
@hussein-awala hussein-awala added the type:new-feature Changelog: New Features label Jan 6, 2024
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

If you want we could fix the Airflow logo text color by changing the fill here

@ncrocfer
Copy link
Contributor Author

ncrocfer commented Jan 8, 2024

Indeed this is a good idea to allow the users to customize it too. I check to append a new commit to this PR if you want.

@ncrocfer
Copy link
Contributor Author

ncrocfer commented Jan 8, 2024

The new navbar_logo_text_color setting (please tell me if you prefer another slug) now allows the customization of the logo text color:

navbar_logo_text_color = #d7cece
Capture d’écran 2024-01-08 à 21 45 38

The default values in the airflow/config_templates/config.yml file keep the current colors:

Capture d’écran 2024-01-08 à 21 47 05

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
@eladkal eladkal merged commit ba2ba7f into apache:main Jan 13, 2024
53 checks passed
@ncrocfer ncrocfer deleted the dev/ncrocfer/navbar_hover branch January 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants