-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow override of hovered navbar colors #36631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
If you want we could fix the Airflow logo text color by changing the fill here
Indeed this is a good idea to allow the users to customize it too. I check to append a new commit to this PR if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
26b8a67
to
9dfbf0a
Compare
This PR is a follow up of the #35505 and #35553 ones to customize the navbar color.
When we hover the links with dark colors we can have this behavior with the background color:
With these new settings the user can override the hovered background and text colors:
cc @vchiapaikeo @eladkal @kaxil @jedcunningham
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.