Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In docs example use logical_date instead of deprecated execution_date #36654

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

fpopic
Copy link
Contributor

@fpopic fpopic commented Jan 7, 2024

First value in airflow deprecated templates table is execution_date, hence replacing example that comes later in text that uses execution_date with logical_date.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@fpopic fpopic changed the title In docs use logical_date instead of deprecated execution_date In docs example use logical_date instead of deprecated execution_date Jan 7, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the correction!

@hussein-awala hussein-awala merged commit a3ebc4d into apache:main Jan 7, 2024
50 checks passed
Copy link

boring-cyborg bot commented Jan 7, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@fpopic fpopic deleted the patch-1 branch January 8, 2024 13:36
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Jan 10, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.1 milestone Jan 10, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants