-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: kubernetes client version #36684
Conversation
# The Kubernetes_asyncio package is used for providing Asynchronous (AsyncIO) client library for | ||
# standard Kubernetes API. The version is limited by minimum 18.20.1 because of introducing the ability to | ||
# load kubernetes config file from dictionary in that release and is limited to the next MAJOR version | ||
# (started from current 24.2.2 version) to prevent introducing some problems that could be due to some | ||
# major changes in the package. | ||
- kubernetes_asyncio>=18.20.1,<25 | ||
- kubernetes_asyncio>=23.6.0,<29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above comment blocks refers to 18.20.1
It needs to be modified
Hmm @raphaelauv - are you planning to update it ? Seems that we do need to bump min-version of the k8s client - see |
@@ -280,8 +280,8 @@ | |||
"asgiref>=3.5.2", | |||
"cryptography>=2.0.0", | |||
"google-re2>=1.0", | |||
"kubernetes>=21.7.0,<24", | |||
"kubernetes_asyncio>=18.20.1,<25" | |||
"kubernetes>=23.6.0,<29", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@potiuk I'm not available to finish this PR in the next days , should I close it ? |
close: #36678