bump: kubernetes client version #36684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
eladkal
reviewed
Jan 9, 2024
| # The Kubernetes_asyncio package is used for providing Asynchronous (AsyncIO) client library for | ||
| # standard Kubernetes API. The version is limited by minimum 18.20.1 because of introducing the ability to | ||
| # load kubernetes config file from dictionary in that release and is limited to the next MAJOR version | ||
| # (started from current 24.2.2 version) to prevent introducing some problems that could be due to some | ||
| # major changes in the package. | ||
| - kubernetes_asyncio>=18.20.1,<25 | ||
| - kubernetes_asyncio>=23.6.0,<29 |
There was a problem hiding this comment.
The above comment blocks refers to 18.20.1
It needs to be modified
|
Hmm @raphaelauv - are you planning to update it ? Seems that we do need to bump min-version of the k8s client - see |
2 tasks
dirrao
reviewed
Jan 25, 2024
| @@ -280,8 +280,8 @@ | |||
| "asgiref>=3.5.2", | |||
| "cryptography>=2.0.0", | |||
| "google-re2>=1.0", | |||
| "kubernetes>=21.7.0,<24", | |||
| "kubernetes_asyncio>=18.20.1,<25" | |||
| "kubernetes>=23.6.0,<29", | |||
|
@potiuk I'm not available to finish this PR in the next days , should I close it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #36678