Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment of template field in __init__ in custom_job #36789

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

romsharon98
Copy link
Contributor

related: #36484

Fix:

CreateCustomContainerTrainingJobOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_name or 
super.__init__(field_name=field_name, ...) ):
['dataset_id', 'region', 'parent_model', 'impersonation_chain']
CreateCustomPythonPackageTrainingJobOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_name or 
super.__init__(field_name=field_name, ...) ):
['dataset_id', 'region', 'parent_model', 'impersonation_chain']
CreateCustomTrainingJobOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_name or 
super.__init__(field_name=field_name, ...) ):
['dataset_id', 'region', 'parent_model', 'impersonation_chain']

cc: @shahar1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 15, 2024
@romsharon98 romsharon98 changed the title Add templated fields to super in vertex_ai Fix assignment of template field in __init__ in vertex_ai Jan 15, 2024
@romsharon98 romsharon98 changed the title Fix assignment of template field in __init__ in vertex_ai Fix assignment of template field in __init__ in vertex_ai Jan 15, 2024
@romsharon98 romsharon98 force-pushed the fix/vertex branch 2 times, most recently from 1024dbb to 314aeca Compare January 15, 2024 11:24
@romsharon98 romsharon98 force-pushed the fix/vertex branch 2 times, most recently from 168e399 to 93943dc Compare January 20, 2024 19:20
@romsharon98 romsharon98 changed the title Fix assignment of template field in __init__ in vertex_ai Fix assignment of template field in __init__ in custom_job Jan 21, 2024
@romsharon98 romsharon98 changed the title Fix assignment of template field in __init__ in custom_job Fix assignment of template field in __init__ in custom_job Jan 21, 2024
@potiuk
Copy link
Member

potiuk commented Feb 5, 2024

Conflicts need resolving.

@potiuk potiuk merged commit 7883bcc into apache:main Feb 7, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants