Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment of template field in __init__ in CloudDataTransferServiceCreateJobOperator #36909

Merged

Conversation

romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Jan 19, 2024

related: #36484

fix:

CloudDataTransferServiceCreateJobOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_name or 
super.__init__(field_name=field_name, ...) ):
['body']
CloudDataTransferServiceCreateJobOperator's constructor contains invalid assignments to the following instance members that should be corresponding to template fields (i.e., self.field_name = 
field_name):
['self.body']

cc: @shahar1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 19, 2024
@romsharon98 romsharon98 force-pushed the fix/cloud-storage-transfer-service branch from dfc0edf to ac95f65 Compare January 20, 2024 19:18
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for str body?

@romsharon98 romsharon98 force-pushed the fix/cloud-storage-transfer-service branch from ac95f65 to d77f115 Compare January 21, 2024 16:29
@romsharon98
Copy link
Contributor Author

Is it possible to add a test for str body?

Added 👍

@hussein-awala hussein-awala merged commit 46470ab into apache:main Feb 4, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants