Enable '_enable_tcp_keepalive' functionality for GKEPodHook #36999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
How about a unit test? |
dirrao
reviewed
Jan 25, 2024
dirrao
requested changes
Jan 26, 2024
MaksYermak
force-pushed
the
gke-enable-tcp-keepalive
branch
from
0f4bad6 to
4ccc954
Compare
MaksYermak
force-pushed
the
gke-enable-tcp-keepalive
branch
from
4ccc954 to
6b7fb17
Compare
potiuk
approved these changes
Jan 26, 2024
81 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have enabled TCP keepalive functionality for GKEPodHook. We have the same functionality for KubernetesHook. Also this PR is a fix for this issue #36802
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.