Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous @Sentry.enrich_errors #37002

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Remove superfluous @Sentry.enrich_errors #37002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa41267
Remove superfluous `@Sentry.enrich_errors` from `TaskInstance._schedu…
jkramer-ginkgo Jan 24, 2024
f3905e6
Fix incorrect parameter name
jkramer-ginkgo Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3227,7 +3227,6 @@ def ti_selector_condition(cls, vals: Collection[str | tuple[str, int]]) -> Colum

@classmethod
@internal_api_call
@Sentry.enrich_errors
@provide_session
def _schedule_downstream_tasks(
cls,
Expand Down
3 changes: 1 addition & 2 deletions airflow/sentry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ def enrich_errors(self, func):
"""
Decorate errors.

Wrap TaskInstance._run_raw_task and LocalTaskJob._run_mini_scheduler_on_child_tasks
to support task specific tags and breadcrumbs.
Wrap TaskInstance._run_raw_task to support task specific tags and breadcrumbs.
"""
session_args_idx = find_session_idx(func)

Expand Down
2 changes: 1 addition & 1 deletion airflow/serialization/pydantic/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def schedule_downstream_tasks(self, session: Session = NEW_SESSION, max_tis_per_
:meta: private
"""
return TaskInstance._schedule_downstream_tasks(
ti=self, sessions=session, max_tis_per_query=max_tis_per_query
ti=self, session=session, max_tis_per_query=max_tis_per_query
)

def command_as_list(
Expand Down
Loading