Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlToS3Operator: feat/ add max_rows_per_file parameter #37055

Conversation

selimchergui
Copy link
Contributor

@selimchergui selimchergui commented Jan 28, 2024

Description
SqlToS3Operator create an S3 object from the output of a sql qurey. Unless you specify a groupby_kwargs parameter, the entire data will be written in one object. This could results on data pipeline issues especially when output files are consumed by limited resources workers (like Kubernetes pods).
So I suggest adding a new paramter, max_rows_per_file, to limit the size of destination files and dispatch output data into multiple files.

Use case/motivation
I faced a lot of out-of-memory issues when trying to process SqlToS3Operator destination object. With such a feature, output will be standardized and next compute worker can easily has an adequate size and a predictable run time.

Code of Conduct
I agree to follow this project's Code of Conduct

Copy link

boring-cyborg bot commented Jan 28, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jan 29, 2024

LGTM

@potiuk
Copy link
Member

potiuk commented Jan 29, 2024

I reverse-quoted a grouby_keywords as spellchecking did not like it, hopefully it will get green and I will be able to merge it

Copy link
Contributor

@syedahsn syedahsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you explicitly fail if both parameters are specified, you could potentially simplify this statement:
if self.max_rows_per_file and not self.groupby_kwargs:
But I'll leave that up to you :)

@potiuk potiuk merged commit 8914e49 into apache:main Jan 30, 2024
55 checks passed
Copy link

boring-cyborg bot commented Jan 30, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Jan 30, 2024

Now that you explicitly fail if both parameters are specified, you could potentially simplify this statement: if self.max_rows_per_file and not self.groupby_kwargs: But I'll leave that up to you :)

Yeah. Thought about that too, but now it is very explicit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants