-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deferrable param in SFTPSensor #37117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:sftp
labels
Jan 31, 2024
pankajkoti
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like CI is failing
Please take a look, they are fixed now. |
pankajkoti
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have a couple of comments
Lee-W
reviewed
Feb 2, 2024
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
utkarsharma2
commented
Feb 2, 2024
This was referenced Feb 2, 2024
pankajkoti
approved these changes
Feb 2, 2024
Lee-W
approved these changes
Feb 2, 2024
Taragolis
approved these changes
Feb 3, 2024
potiuk
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Add deferrable param in SFTPSensor * Fix static checks * Fixed duplicate task_id issue * Add missing tests * Fix failing test cases * Fix provider.yaml static check * Update airflow/providers/sftp/sensors/sftp.py Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * Update airflow/providers/sftp/sensors/sftp.py * Removed get_files_by_pattern * Change the name for rst marker - howto_sensor_sftp_deferrable * Handle missing file case for triggers --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> (cherry picked from commit f24a037)
potiuk
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Feb 8, 2024
81 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Add deferrable param in SFTPSensor * Fix static checks * Fixed duplicate task_id issue * Add missing tests * Fix failing test cases * Fix provider.yaml static check * Update airflow/providers/sftp/sensors/sftp.py Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * Update airflow/providers/sftp/sensors/sftp.py * Removed get_files_by_pattern * Change the name for rst marker - howto_sensor_sftp_deferrable * Handle missing file case for triggers --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> (cherry picked from commit f24a037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
area:system-tests
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
kind:documentation
provider:sftp
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced a deferrable param in SFTPSensor.