Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable param in SFTPSensor #37117

Merged
merged 14 commits into from
Feb 3, 2024
Merged

Conversation

utkarsharma2
Copy link
Contributor

This PR introduced a deferrable param in SFTPSensor.

Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is failing

@utkarsharma2
Copy link
Contributor Author

looks like CI is failing

Please take a look, they are fixed now.

Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a couple of comments

airflow/providers/sftp/sensors/sftp.py Outdated Show resolved Hide resolved
airflow/providers/sftp/sensors/sftp.py Outdated Show resolved Hide resolved
airflow/providers/sftp/hooks/sftp.py Outdated Show resolved Hide resolved
airflow/providers/sftp/hooks/sftp.py Show resolved Hide resolved
tests/system/providers/sftp/example_sftp_sensor.py Outdated Show resolved Hide resolved
airflow/providers/sftp/hooks/sftp.py Show resolved Hide resolved
airflow/providers/sftp/hooks/sftp.py Outdated Show resolved Hide resolved
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
@Taragolis Taragolis merged commit f24a037 into apache:main Feb 3, 2024
82 checks passed
potiuk pushed a commit that referenced this pull request Feb 7, 2024
* Add deferrable param in SFTPSensor

* Fix static checks

* Fixed duplicate task_id issue

* Add missing tests

* Fix failing test cases

* Fix provider.yaml static check

* Update airflow/providers/sftp/sensors/sftp.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

* Update airflow/providers/sftp/sensors/sftp.py

* Removed get_files_by_pattern

* Change the name for rst marker - howto_sensor_sftp_deferrable

* Handle missing file case for triggers

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
(cherry picked from commit f24a037)
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 8, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 8, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
* Add deferrable param in SFTPSensor

* Fix static checks

* Fixed duplicate task_id issue

* Add missing tests

* Fix failing test cases

* Fix provider.yaml static check

* Update airflow/providers/sftp/sensors/sftp.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

* Update airflow/providers/sftp/sensors/sftp.py

* Removed get_files_by_pattern

* Change the name for rst marker - howto_sensor_sftp_deferrable

* Handle missing file case for triggers

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
(cherry picked from commit f24a037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:sftp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants