-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Fix cluster-wide RBAC naming clash when using multiple multiNamespace releases with the same name #37197
Conversation
Multinamespace is not yet fully supported. It should be added with #35639 |
I took a quick look at it and they seem to support different scenarios. I believe the above PR means to introduce fine-grained RBAC controls when using Whereas, this PR fixes the behaviour with the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a default value in valyes.yaml for multiNamespaceMode? @mewa
@amoghrajesh It already defaults to Lines 2389 to 2391 in 4c37328
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying.
Looks good!
Static checks are failing |
I updated the newsfragment to satisfy the checks. I also moved it to significant type since it involves renaming of the resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But would love also @jedcunningham 's pair of eyes on it.
Ah... We already had a lot of eyes I see.. |
…ode and the same release name in multiple namespaces
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @mewa! Congrats on your first commit 🍺 |
Currently, when deploying multiple releases that share the same release name in different namespaces deployment is failing due to a naming clash of the cluster-scoped RBAC resources.
This PR introduces changes that make sure that
ClusterRole
s andClusterRoleBinding
s are uniquely named according to both the release name, as well as the release namespace, thus solving the naming clash.Steps to reproduce current behavior:
airflow-a
airflow
into namespaceairflow-a
withmultiNamespaceMode: true
airflow-b
airflow
into namespaceairflow-b
withmultiNamespaceMode: true
Related: #31613 (closed, resubmitting with updated tests)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.