Remove unused pageSize method. #37319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
|
Or should we remove the whole function ? @bbovenzi @pierrejeambrun - from what I see, the whole |
potiuk
changed the title
dirrao
approved these changes
Feb 11, 2024
Yeah, I don't see where we define anything with |
potiuk
force-pushed
the
escape-page-size
branch
from
1cd1ddc
to
69f697e
Compare
potiuk
changed the title
potiuk
force-pushed
the
escape-page-size
branch
from
69f697e
to
e7e38b6
Compare
Removed. |
|
cc: @bbovenzi |
hussein-awala
approved these changes
Feb 12, 2024
eladkal
approved these changes
Feb 12, 2024
bbovenzi
approved these changes
Feb 12, 2024
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 5fe27c8)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 5fe27c8)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.