Get rid of pytest-httpx as dependency #37334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Taragolis
reviewed
Feb 11, 2024
Taragolis
approved these changes
Feb 11, 2024
potiuk
force-pushed
the
get-rid-of-pytest-httpx
branch
from
debe966
to
0232829
Compare
|
I forgot I also need to change EPOCH to not let the dependency stay in cache. |
potiuk
force-pushed
the
get-rid-of-pytest-httpx
branch
from
0232829
to
5f7f6db
Compare
We were using it in one test case only that can be easily mocked manually. Pytest-httpx blocks us from upgrading to pytest 8 because the newer versions of it that support Pytest 8 have Python >= 3.9. At the same time we make explicit dependency on requirements which are also used internally and bump min version to 2.27.0 which is already more than year long and some of our providers already had this min version set.
potiuk
force-pushed
the
get-rid-of-pytest-httpx
branch
from
5f7f6db
to
ca9d285
Compare
Taragolis
reviewed
Feb 11, 2024
hussein-awala
approved these changes
Feb 11, 2024
81 tasks
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Feb 13, 2024
We were using it in one test case only that can be easily mocked manually. Pytest-httpx blocks us from upgrading to pytest 8 because the newer versions of it that support Pytest 8 have Python >= 3.9. At the same time we make explicit dependency on requirements which are also used internally and bump min version to 2.27.0 which is already more than year long and some of our providers already had this min version set. (cherry picked from commit 78294c2)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
We were using it in one test case only that can be easily mocked manually. Pytest-httpx blocks us from upgrading to pytest 8 because the newer versions of it that support Pytest 8 have Python >= 3.9. At the same time we make explicit dependency on requirements which are also used internally and bump min version to 2.27.0 which is already more than year long and some of our providers already had this min version set. (cherry picked from commit 78294c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using it in one test case only that can be easily mocked manually. Pytest-httpx blocks us from upgrading to pytest 8 because the newer versions of it that support Pytest 8 have Python >= 3.9.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.