Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip "." path when preparing reproducible packages #37402

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 13, 2024

The packages should not contain the "." folder.

Fixes #37399


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The packages should not contain the "." folder.

Fixes apache#37399
@potiuk potiuk added this to the Airflow Helm Chart 1.12.1 milestone Feb 13, 2024
@potiuk potiuk merged commit 9593fb7 into apache:main Feb 13, 2024
84 checks passed
@potiuk potiuk deleted the skip_dot_path_for_reproducible_packages branch February 13, 2024 23:06
@potiuk potiuk modified the milestones: Airflow Helm Chart 1.12.1, Airflow 2.8.2 Feb 13, 2024
@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2024

cc: @jedcunningham -> I guess this one should be added manually to changelog as it will be skipped in Chart changelog.

@potiuk potiuk modified the milestones: Airflow 2.8.2, Airflow Helm Chart 1.12.1 Feb 13, 2024
@finaldie
Copy link

May I ask when the helm chart 1.12.1 will be released? it's currently blocked the argoCD deployment. Thanks a lot.

@potiuk
Copy link
Member Author

potiuk commented Feb 27, 2024

Airflow 2.8.2 has been just released so I believe soon. Please make sure to subscribe to devllst when the release candidate for you to test (https://airflow.apache.org/community/ to see how) .

If you are after speeding up the release - this is THE way you and anyone else waiting for it, can help in speeding up the release/

Can we count on you to get it to a spin and confirm that it works as expected when RC is out @finaldie ?

@potiuk
Copy link
Member Author

potiuk commented Feb 27, 2024

BTW. I will be quite disappointed not seeing your "I've tested it, it works" or "Here are the problems I found" of yours when we ask for it.

@jedcunningham jedcunningham modified the milestones: Airflow Helm Chart 1.12.1, Airflow Helm Chart 1.13.0 Feb 28, 2024
@finaldie
Copy link

finaldie commented Mar 5, 2024

Thanks team, verified for the helm chart 1.13.0 with argocd in GCP, it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow Helm chart fails to deploy with ArgoCD
4 participants