Flower K8s Probe config #37528
Merged
Flower K8s Probe config #37528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seokyun-Ha
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
There was a problem hiding this comment.
Good idea! Could you add a test to ensure that everything works as expected?
https://github.com/apache/airflow/blob/main/helm_tests/other/test_flower.py
|
hello, @hussein-awala ! I added probe values cofigurable test as you pointed 🙏 Thanks for reviewing!! |
potiuk
approved these changes
Feb 20, 2024
6 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to control flower probe configuration on helm values file.
Because, I think that the flower probe period is too often (
5s), and I want to customize it 🙏Please, take a look at, and let me know if there's something I missed 😄
reference kubernetes doc: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.