-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(main): fix ImportError on examples dags #37571
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Just one static check to fix |
e26972c
to
b8a66c2
Compare
i submitted fixes for the static checks. It should pass now |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* fix(main): fix ImportError on examples dags * thanks @eladkal * @Taragolis thanks for the review, you absoultly right. bad styling, overthinking. * Fix static check failure * Update tests/system/README.md * Update dev/PROJECT_GUIDELINES.md --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> (cherry picked from commit e0fc803)
this pull request is related to: apache/airflow-site#945
closes: apache/airflow-site#945
the solution of "skipped" on the dag-loading when the virtualenv is not installed
is wrap the dag loading with try-except and return None either
using this logic will guarantee the ImportError exception will not stored in the DB
and not thrown on the homepage as an error.
so if virtualenv is not installed the examples are not loaded and the exception will not thrown
tested on Ubuntu WSL2