Introduce mechanism to support multiple executor configuration #37635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-nikolas
requested review from
kaxil,
XD-DENG,
ashb,
pierrejeambrun and
hussein-awala
as code owners
boring-cyborg
bot
added
the
area:Executors-core
This commit delivers an isolated component of AIP-61: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-61+Hybrid+Execution It updates the executor configuration logic to allow configuring multiple executors (and aliases per executor) in a list form (comma delimited), as well as associated methods for core Airflow code to load the default executor (first executor in the list) or any other configured executor. Testing is included with the changes but not documentation, because the feature is not yet complete and is currently disabled. User facing documentation will be delivered when the entire AIP-61 feature is released.
o-nikolas
force-pushed
the
onikolas/aip-61/multiple_exec_config
branch
from
43b6b7a to
de6dca1
Compare
|
Converting to draft while I work on test failures ❤️ |
Executor data is now more aggressively cached and this was failing some tests that are trying to override the executor conf. Moved the caches to the module level and added some reload(executor_loader) calls to empty the caches for certain tests that require it.
This unit test was broken to begin with and was working mostly by chance. Updated the patch to be the correct method to mock and test is passing again
o-nikolas
force-pushed
the
onikolas/aip-61/multiple_exec_config
branch
from
d04cb0c to
68b920b
Compare
o-nikolas
commented
Feb 26, 2024
o-nikolas
commented
Feb 26, 2024
o-nikolas
commented
Feb 26, 2024
o-nikolas
commented
Feb 26, 2024
vincbeck
approved these changes
Feb 28, 2024
potiuk
reviewed
Mar 2, 2024
potiuk
reviewed
Mar 2, 2024
syedahsn
reviewed
Mar 4, 2024
syedahsn
approved these changes
Mar 4, 2024
|
Do you have time to have another look and approve? I've made your suggestion and rebased and tests are green |
potiuk
approved these changes
Mar 9, 2024
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
…e#37635) * Introduce mechanism to support multiple executor configuration This commit delivers an isolated component of AIP-61: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-61+Hybrid+Execution It updates the executor configuration logic to allow configuring multiple executors (and aliases per executor) in a list form (comma delimited), as well as associated methods for core Airflow code to load the default executor (first executor in the list) or any other configured executor. Testing is included with the changes but not documentation, because the feature is not yet complete and is currently disabled. User facing documentation will be delivered when the entire AIP-61 feature is released. * Move caches to module and use reloads to empty them in tests Executor data is now more aggressively cached and this was failing some tests that are trying to override the executor conf. Moved the caches to the module level and added some reload(executor_loader) calls to empty the caches for certain tests that require it. * Fix TestBaseSensor::test_prepare_for_execution This unit test was broken to begin with and was working mostly by chance. Updated the patch to be the correct method to mock and test is passing again * More reloads * Comment grammar fix * New code needed a reload of executor loader module * Fix unit test is-->are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit delivers an isolated component of AIP-61: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-61+Hybrid+Execution
It updates the executor loader logic to allow configuring multiple executors (and aliases per executor) in a list form (comma delimited) from airflow configuration; as well as associated methods for core Airflow code to load the default executor (first executor in the list) or any other configured executor.
Testing is included with the changes but not documentation, because AIP-61 is not yet complete. The code delivered is behind gating logic that will prohibit users from accidentally using it. User facing documentation will be delivered when the entire AIP-61 feature is fully completed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.