Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dag Audit Log to React #37682

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Add Dag Audit Log to React #37682

merged 2 commits into from
Feb 25, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Feb 24, 2024

Continue modernizing the UI. Use the REST API show the Audit Log for a DAG in react.

The Audit Log shows up as a tab for every selection (dag, dag run, task, task instance). And we try to filter the Audit Log accordingly, within the limitations we have at least.

Run ID isn't recorded and execution date is not currently a parameter (nor do we always record the execution date or map index anyway). So instead when there is a dag run, we filter the before/after dates to the queued at and last scheduling decision dates.

Also cleaned up the logic of what tabs to default to when changing selection.

Task Instance Selected (filtered by before, after and task id)
Screenshot 2024-02-24 at 5 09 30 PM

Task is selected (filtered by task id)
Screenshot 2024-02-24 at 5 09 51 PM

Nothing selected (only filtered by dag id)
Screenshot 2024-02-24 at 5 09 42 PM

Dag Run selected (filtered by before and after)
Screenshot 2024-02-24 at 5 09 37 PM

ToDo in later PRs:

  • Remove old DAG Audit Log page
  • Allow user to edit filters directly instead of via task selection and add more filters
  • Allow multiple task ids as a parameter (can filter by task group)

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Feb 24, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 24, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM

@bbovenzi bbovenzi merged commit 29b3a30 into apache:main Feb 25, 2024
56 checks passed
@bbovenzi bbovenzi deleted the react-audit-log branch February 25, 2024 15:38
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants