Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min versions of openapi validators #37691

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 25, 2024

The openapi validators in older versions do not work well for some moto tests which use the validators. Bumping specifically the min versions of those validators should help with better dependency resolving (wheb using uv and lowest transitive versions strategy it will downgrade the validators and will cause the tests to fail as seen in #37683.

Those are only test and development dependencies and we already use the min version specified in our CI, so it should have no impact on production airflow (but should help wiht CI/dependency resolution)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The openapi validators in older versions do not work well for some
moto tests which use the validators. Bumping specifically the
min versions of those validators should help with better
dependency resolving (wheb using uv and lowest transitive versions
strategy it will downgrade the validators and will cause the tests
to fail as seen in apache#37683.

Those are only test and development dependencies and we already use
the min version specified in our CI, so it should have no impact
on production airflow (but should help wiht CI/dependency resolution)
@potiuk potiuk merged commit f3159df into apache:main Feb 25, 2024
80 checks passed
@potiuk potiuk deleted the bump-min-versions-for-openapi-validators branch February 25, 2024 17:28
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.3 milestone Mar 6, 2024
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 6, 2024
ephraimbuddy pushed a commit that referenced this pull request Mar 6, 2024
The openapi validators in older versions do not work well for some
moto tests which use the validators. Bumping specifically the
min versions of those validators should help with better
dependency resolving (wheb using uv and lowest transitive versions
strategy it will downgrade the validators and will cause the tests
to fail as seen in #37683.

Those are only test and development dependencies and we already use
the min version specified in our CI, so it should have no impact
on production airflow (but should help wiht CI/dependency resolution)

(cherry picked from commit f3159df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants