-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid use of assert
outside of the tests
#37718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Feb 26, 2024
Taragolis
requested review from
potiuk,
ashb,
jedcunningham,
uranusjr,
kaxil,
bolkedebruin and
XD-DENG
as code owners
February 26, 2024 17:32
Taragolis
commented
Feb 26, 2024
airflow/providers/fab/auth_manager/security_manager/override.py
Outdated
Show resolved
Hide resolved
Taragolis
commented
Feb 26, 2024
potiuk
approved these changes
Feb 26, 2024
vincbeck
approved these changes
Feb 26, 2024
Taragolis
force-pushed
the
avoid-assert-out-of-tests
branch
2 times, most recently
from
March 1, 2024 13:32
1ab3acd
to
eee0897
Compare
uranusjr
reviewed
Mar 1, 2024
Taragolis
force-pushed
the
avoid-assert-out-of-tests
branch
from
March 3, 2024 14:49
4fac70e
to
12ee347
Compare
Taragolis
force-pushed
the
avoid-assert-out-of-tests
branch
from
March 8, 2024 10:36
12ee347
to
f1c0f21
Compare
Also fix Batch Executor Config |
mobuchowski
approved these changes
Mar 11, 2024
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
ephraimbuddy
added
the
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Mar 14, 2024
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:CLI
area:dev-tools
area:providers
area:secrets
area:serialization
full tests needed
We need to run full set of tests for this PR to merge
provider:alibaba
provider:fab
provider:microsoft-psrp
provider:openlineage
AIP-53
provider:yandex
type:misc/internal
Changelog: Misc changes that should appear in change log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
S101
for make sure that we follow https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#dont-use-asserts-outside-testsThis exact the same rule which use by bandit
B101
, however ruff have some significant benefit - it ignore this rule inside ofTYPE_CHECKING
which might use for makemypy
happy and do not executed in runtime.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.