Add Run Duration in React #37735
Merged
Add Run Duration in React #37735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
|
+1 to this. I guess with the migration from tree to grid view sort of gives the dag run duration as a mini chart. It will help in seeing landing times where difference between scheduled run and start time is also useful and also porting the old server rendered html page. |
bbovenzi
force-pushed
the
react-landing-time
branch
from
5800f71
to
1c905d5
Compare
jscheffl
approved these changes
Feb 29, 2024
|
Do we need to adjust Docs or update screenshots in Docs with this PR? Otherwise LGTM! |
I'll do an audit of our docs before 2.9 comes out. I still need to get rid of the old page and make some other visual changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to task duration but for dag runs. At first this was to replace the Landing Time chart, which made more sense at a dag run level vs a task instance level. But instead decided to make it a full view and allow users to toggle Landing Times on/off.
(This is a daily dag with an old start_date and catchup is true)
You can also see queued time for a dag run:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.