Avoid change attributes into the constructor in Apache Beam operators #37934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid operation (assign, checks, cast) on potential templated fields into the Apache Beam Operators, all logic moved into the execute method
Avoid use mutable in the session scope into the tests.
Avoid create operators before test cases
In addition I install locally
pytest-random-order
and run for about 20 timespytest tests/providers/apache/beam/operators/test_beam.py --random-order
without any side effectOperators still have a lot of logic which assign a lot of attributes into the runtime in specific order.
BeamDataflowMixin
looks useless because it only provided private methods and assign to the all operators.But maybe this should be resolved as a follow up.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.