Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make current working directory as templated field in BashOper… #37952

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 6, 2024

…ator (#37928)"

This reverts commit db07eb1.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Mar 6, 2024
@potiuk potiuk requested a review from Taragolis March 6, 2024 20:59
@vincbeck
Copy link
Contributor

vincbeck commented Mar 6, 2024

Thanks! I was going to do it!

@potiuk potiuk merged commit 35fef2b into apache:main Mar 6, 2024
18 checks passed
@potiuk potiuk deleted the revert-cwd-bash-operator-change branch March 6, 2024 21:00
@potiuk
Copy link
Member Author

potiuk commented Mar 6, 2024

cc: @Taragolis -> the #37928 shoud be re-done and full tests needed addded - as it adds a number of cwd added in serialization tests and other places.

@Taragolis
Copy link
Contributor

Taragolis commented Mar 6, 2024

Re-revert with fixes 😉 I guess it also might be a good idea add bash operator as full-test triggerer in selective checks since changes in BashOperator might affect other tests

@potiuk
Copy link
Member Author

potiuk commented Mar 6, 2024

I guess it also might be a good idea add bash operator as full-test triggerer in selective checks since changes in BashOperator might affect other tests

Yeah. looks like. We can add a rule for that - maybe not full tests but contributing Core and Serialization test cases. Let me take a look.

@potiuk
Copy link
Member Author

potiuk commented Mar 6, 2024

PR here: #37953

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 14, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants