-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AwsLogsHook when fetching Glue job logs #38010
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This PR aim to fix a bug in the GlueJobHook that occurs when setting the
verbose
parameter of GlueJobOperator to True.The
print_job_logs
method is instantiating a new boto3 client instead of using an AwsLogsHook.https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/hooks/glue.py#L228
If the
GlueJobOperator
is instantiated with an Airflow Connection with arole_arn
different than the one used by the Airflow Workers, it result in aAccessDeniedException
(because the boto3 client is using the default credentials)To fix this bug I've deleted the boto3 client instantiated in the
print_job_logs
method and instead, created a newAwsLogsHook
using theaws_conn_id
attribute.Close #37976