Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AwsLogsHook when fetching Glue job logs #38010

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Conversation

VincentChantreau
Copy link
Contributor

@VincentChantreau VincentChantreau commented Mar 9, 2024

This PR aim to fix a bug in the GlueJobHook that occurs when setting the verbose parameter of GlueJobOperator to True.
The print_job_logs method is instantiating a new boto3 client instead of using an AwsLogsHook.

https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/hooks/glue.py#L228

If the GlueJobOperator is instantiated with an Airflow Connection with a role_arn different than the one used by the Airflow Workers, it result in a AccessDeniedException (because the boto3 client is using the default credentials)

To fix this bug I've deleted the boto3 client instantiated in the print_job_logs method and instead, created a new AwsLogsHook using the aws_conn_id attribute.

Close #37976

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Mar 9, 2024
Copy link

boring-cyborg bot commented Mar 9, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@VincentChantreau VincentChantreau marked this pull request as ready for review March 9, 2024 13:21
@vincbeck vincbeck merged commit 1d3a00a into apache:main Mar 11, 2024
55 checks passed
Copy link

boring-cyborg bot commented Mar 11, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glue Hook not using aws_conn_id for logs access resulting in Error
5 participants