-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google,log): Avoid log name overriding #38071
fix(google,log): Avoid log name overriding #38071
Conversation
e3487c1
to
812ad29
Compare
812ad29
to
c2b9843
Compare
Please notice that static tests fail |
932c339
to
4b999dd
Compare
I updated the PR to print a warning when using the |
Try to copy similar logic from existing tests |
4b999dd
to
632411b
Compare
Seems good. Failing tests don't seem to be linked to my code. |
eb1eae8
to
ce39fec
Compare
Errors + static checks need to be fixed. |
Static checks are about single line newsgragment. But the comment from @eladkal suggests to add more info than a single line. Is there a way to by-pass this check or should I put the explanation somewhere else ? |
Yes. use |
ce39fec
to
2618e13
Compare
2618e13
to
e81b66a
Compare
Avoid the use of the generic `name` attribute which is overrode by the dict configurator.
e81b66a
to
3ec4dc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Avoid the use of the generic `name` attribute which is overrode by the dict configurator. (cherry picked from commit 091d5e6)
Avoid the use of the generic
name
attribute which is overrode by the dict configurator.I'm not sure if this change break the backward compatibility (
name
attribute is "public" and maybe someone do some things with it...).