Allow sort by on all fields in MappedInstances.tsx #38090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNHTTR
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
|
The sort for those fields is disabled because the REST API only supports map index and state right now. We would need to update it there too. See here for API code |
uranusjr
reviewed
Apr 11, 2024
uranusjr
approved these changes
Apr 12, 2024
bbovenzi
reviewed
Apr 16, 2024
airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx
Outdated
Show resolved
Hide resolved
It's difficult to find problematic TIs when attempting to debug tasks that have dozens or hundreds of mapped TIs
….tsx Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
jedcunningham
added
type:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to find problematic TIs when attempting to debug tasks that have dozens or hundreds of mapped TIs. For example, imagine 99 mapped instances completed in 10 seconds but 1 mapped instance took 10 minutes. It's like finding a needle in a haystack to find that one.
This will allow users to sort by each field in the grid view.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.