Fix task instances list link #38096
Merged
Fix task instances list link #38096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
uranusjr
approved these changes
Mar 12, 2024
dirrao
approved these changes
Mar 13, 2024
eladkal
approved these changes
Mar 13, 2024
potiuk
approved these changes
Mar 13, 2024
|
Breeze |
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
|
Hi. @bbovenzi , @potiuk I looked at the code in the commit and it seems to me that the "root" part of the link is omitted in the url_root. Old one: New one: There is no root in the new one. I think, the "root" filtering (very helpful in large Dags) should remain, only "task_id" should be added. |
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 18, 2024
We have links to the graph, filtered down to a specific TI. This was accidentally broken in apache#38096.
Merged
jedcunningham
added a commit
that referenced
this pull request
Mar 18, 2024
We have links to the graph, filtered down to a specific TI. This was accidentally broken in #38096.
jedcunningham
pushed a commit
that referenced
this pull request
Mar 18, 2024
(cherry picked from commit 43d7f6d)
jedcunningham
added a commit
that referenced
this pull request
Mar 18, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38030
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.