-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect serialisation of the FixedTimezone #38139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
Mar 14, 2024
I hate Pendulum’s timezone classes |
You are not alone |
I expect that this happen only in Pendulum 3 because inheritance of pendulum timezones changed in that version. Let's me join to the club who hate pendulum timezones😅 |
Taragolis
approved these changes
Mar 15, 2024
This issue introduced in Airflow 2.8. When the `start_date` of a DAG is specified with a fixed timezone, its serialisation will not be correct and this causes the scheduler to crash.
eladkal
approved these changes
Mar 16, 2024
Maybe this fix should be cherry-picked to the 2.8.4 version? |
potiuk
pushed a commit
that referenced
this pull request
Mar 19, 2024
This issue introduced in Airflow 2.8. When the `start_date` of a DAG is specified with a fixed timezone, its serialisation will not be correct and this causes the scheduler to crash. (cherry picked from commit 0720ea0)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
start_date
of a DAG is specified with a fixed timezone, its serialisation will not be correct and this causes the scheduler to crash.Example of an entry in the
data
column of the tableserialized_dag
before fix:
after fix:
Crash log
This issue introduced in Airflow 2.8.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.