-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeptuneStopDbClusterOperator - Handle invalid cluster states #38287
Conversation
@ferruzzi This is the PR for the neptune operators. |
@ellisms is the PR ready for re-review? |
@eladkal Not yet, just getting back into the office. Working on making the suggested changes. |
This is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple nitpicks, but nothing blocking. Feel free to resolve them if you disagree with any of them.
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
…apache#38287) * Cache s3 resource to reduce memory usage * Fixed missing rebase changes and error in resource init * catch invalid state exceptions and wait if not terminal status * PR changes * Update airflow/providers/amazon/aws/triggers/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * PR review changes. Created helper function to deal with waitable ClientErrors * added missing exception code * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * fix static checks * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * minor PR changes --------- Co-authored-by: Niko Oliveira <onikolas@amazon.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
…apache#38287) * Cache s3 resource to reduce memory usage * Fixed missing rebase changes and error in resource init * catch invalid state exceptions and wait if not terminal status * PR changes * Update airflow/providers/amazon/aws/triggers/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Niko Oliveira <onikolas@amazon.com> * PR review changes. Created helper function to deal with waitable ClientErrors * added missing exception code * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * fix static checks * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * Update airflow/providers/amazon/aws/operators/neptune.py Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> * minor PR changes --------- Co-authored-by: Niko Oliveira <onikolas@amazon.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
closes #38120
Handles case where the stop cluster api returns either InvalidClusterState or InvalidDBInstanceState exceptions. The operator now uses the waiter to wait for the cluster to be available. Also updated the start cluster operator to do the same.