Add a possibility to remove the dependency from cache in a PR #38312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you rmeove a dependency from pyproject.toml, until your PR gets merged, it is still present in the main branch of Airflow and this is where we do a "warm" cache install of dependencies when we build the CI image. So the dependency is stil there when your PR is running tests. In order to remove the dependency for the time of PR, we need to remove it manually in the script that installs dependencies from branch tip (and also changing this script will trigger Docker cache invalidation of the branch tip installation step). This PR adds ability to specify the package you remove to also be removed after "branch tip" installation. After merging your PR, it should be fine to remove it again from the branch tip.
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
requested review from
Taragolis,
bbovenzi,
hussein-awala,
josh-fell and
pankajkoti
Member
Author
|
Cache invalidation is the most difficult thing ... |
eladkal
approved these changes
Mar 20, 2024
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you rmeove a dependency from pyproject.toml, until your PR gets merged, it is still present in the main branch of Airflow and this is where we do a "warm" cache install of dependencies when we build the CI image. So the dependency is stil there when your PR is running tests. In order to remove the dependency for the time of PR, we need to remove it manually in the script that installs dependencies from branch tip (and also changing this script will trigger Docker cache invalidation of the branch tip installation step).
This PR adds ability to specify the package you remove to also be removed after "branch tip" installation. After merging your PR, it should be fine to remove it again from the branch tip.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.